no longer deploy local routees when clustered pool router is on wrong role type #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pool router is on wrong role type
Aaronontheweb
commented
Jun 26, 2017
| @@ -131,7 +131,7 @@ public void UseRoleIgnoredSpecs() | |||
| A_cluster_must_start_cluster(); | |||
| A_cluster_must_pool_local_off_roles_off(); | |||
| A_cluster_must_group_local_off_roles_off(); | |||
| //A_cluster_must_pool_local_on_role_b(); | |||
| A_cluster_must_pool_local_on_role_b(); | |||
There was a problem hiding this comment.
Allowed to test to run
| // for binary backwards compatibility reasons | ||
| var deprecatedNrOfInstances = pool.NrOfInstances; | ||
|
|
||
| var nrOfRoutees = deprecatedNrOfInstances < 0 |
There was a problem hiding this comment.
any routers that are compiled without NrOfInstances(ActorSystem) can't run on 1.1 or later anyway.
|
@Aaronontheweb looks like a spec failed on Windows: |
|
@heynickc yeah that one needs some hardening, but that spec failure is unrelated to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2783