Fixed node transition spec #2788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jun 22, 2017
| return roles.First(); | ||
| // sorts the addresses and provides the address of the node with the lowest port number | ||
| // as that node will be the leader | ||
| return roles.Select(x => Tuple.Create(x, GetAddress(x).Port)).OrderBy(x => x.Item2).First().Item1; |
There was a problem hiding this comment.
This was the fix - needed to be able to correctly pick the leader from the remaining nodes and not just assume that the first node in the list == the leader.
Aaronontheweb
commented
Jun 22, 2017
| @@ -61,7 +64,7 @@ private RoleName[] NonLeader(params RoleName[] roles) | |||
|
|
|||
| private MemberStatus MemberStatus(Address address) | |||
| { | |||
| var status = ClusterView.Members.Concat(ClusterView.UnreachableMembers) | |||
| var status = ClusterView.Members.Union(ClusterView.UnreachableMembers) | |||
There was a problem hiding this comment.
Used the Union method here to filter out duplicates and be consistent with the JVM.
Aaronontheweb
commented
Jun 22, 2017
| @@ -256,6 +259,7 @@ private void A_Cluster_must_perform_correct_transitions_when_third_joins_second( | |||
| EnterBarrier("convergence-joining-3"); | |||
|
|
|||
| var leader12 = Leader(_config.First, _config.Second); | |||
| Log.Debug("Leader: {0}", leader12); | |||
There was a problem hiding this comment.
Used this to help expose the bug; won't log anything by default since we run with DebugConfig = false
|
FYI, the change that is missing is just this FAKE backport for once we split .NET Core tests on Doesn't affect the Akka.NET code itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2014