Skip to content

Serialization reload on settings change #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2017
Merged

Serialization reload on settings change #2730

merged 7 commits into from
Aug 11, 2017

Conversation

zbynek001
Copy link
Contributor

Serializers configurations from extension default config are not correctly loaded.
At the time extension tries to inject it's default config with InjectTopLevelFallback, serializer configuration was already loaded and it's not reloaded afterwards. Currently only workaround I know about is providing all fallback configurations when creating ActorSystem itself. This pr tries to improve this.

@zbynek001 zbynek001 changed the title [WIP] Serialization reload on settings change Serialization reload on settings change Jun 13, 2017
@zbynek001
Copy link
Contributor Author

Not sure if there is a better way how to handle this scenario.
And maybe it soon won't be needed with the change to persistence serialization

@Aaronontheweb
Copy link
Member

@zbynek001 which serializers do you have this problem for? User-defined ones?

@zbynek001
Copy link
Contributor Author

zbynek001 commented Aug 9, 2017 •
edited
Loading

I've run into this with singleton & sharding. During startup, they are trying to inject default configs via InjectTopLevelFallback which works for most stuff, but not for "akka.actor.serializers" configuration. Those never get updated because they were already loaded.
So the only workaround is to provide complete configuration before ActorSystem itself starts

@zbynek001 zbynek001 force-pushed the serialization-settings branch from 4c9e017 to 7e5bda4 Compare August 9, 2017 09:59
@Danthar
Copy link
Member

Danthar commented Aug 9, 2017

Looks good to me. We do the same thing for the Dispatchers subsystem as well. The change in itself is good.

@zbynek001
Copy link
Contributor Author

will check the failing test

@zbynek001
Copy link
Contributor Author

Should be fixed by #2952

@zbynek001
Copy link
Contributor Author

reason was that two nodes (those with sharding) were using ClusterShardingMessageSerializer, and the Control node was using hyperion so it was not able to deserialize some messages

@Aaronontheweb Aaronontheweb added this to the 1.3.0 milestone Aug 10, 2017
Aaronontheweb
Aaronontheweb approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Aaronontheweb Aaronontheweb merged commit 9f61d8a into akkadotnet:v1.3 Aug 11, 2017
@zbynek001 zbynek001 deleted the serialization-settings branch June 24, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
reviewed positively serialization
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zbynek001 @Aaronontheweb @Danthar @Horusiath @alexvaluyskiy