Update F# projects to the last FSharp.Core version (4.4.1.0) #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ FSharp.Core dependency comes from nuget
|
Ok, I reproduce the failing test and error locally. I'll work on it from there |
|
@tjaskula perf test may need more than one run. Since they are sort-of dependent on actual state of the underlying hardware, they can occasionally return false negatives. |
|
@Horusiath Cool, it seems that it passes now. I thought that the failling test was unrelated to the build error we had above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsprojand it's making a confusionSystem.ValueTupleis brought along with the latest FSharp.Core.dll