Persistence Refactoring #2634
Persistence Refactoring #2634
Conversation
alexvaluyskiy
commented
Apr 27, 2017
- Fixed racing conditions in the tests
- Removed dead code
- Use C# 6
- Added XML documentation
| /// TBD | ||
| /// </summary> | ||
| /// <param name="payload">TBD</param> | ||
| /// <param name="sender">TBD</param> | ||
| public NonPersistentMessage(object payload, IActorRef sender) |
There was a problem hiding this comment.
Internal code should not contains TBD Xml comments
| @@ -249,22 +248,6 @@ private void HandleDeleteMessagesTo(DeleteMessagesTo message) | |||
| }, _continuationOptions); | |||
| } | |||
|
|
|||
| private void HandleReadHighestSequenceNr(ReadHighestSequenceNr message) | |||
| /// </summary> | ||
| /// <param name="context">TBD</param> | ||
| /// <param name="message">TBD</param> | ||
| public static void EnqueueMessageFirst(this IActorContext context, object message) |
| { | ||
| internal static class CollectionsExtensions | ||
| { | ||
| public static ImmutableArray<T> AddFirst<T>(this ImmutableArray<T> @this, T item) |
There was a problem hiding this comment.
Emulated LinkedList
There was a problem hiding this comment.
Have you checked the performance? AFAIK LinkedList AddFirst operation is O(1). Using ImmutableArray is copying the whole array into new struct: implementation.
There was a problem hiding this comment.
Yes, this one is slower. But I'm using it only in unit tests
| /// TBD | ||
| /// </summary> | ||
| [Serializable] | ||
| public sealed class ReadHighestSequenceNr : IJournalRequest, IEquatable<ReadHighestSequenceNr> |
There was a problem hiding this comment.
Dead code from the pre-2.4 persistence
| @@ -121,7 +123,7 @@ public override string ToString() | |||
|
|
|||
| internal abstract class ExamplePersistentActor : NamedPersistentActor | |||
| { | |||
| protected LinkedList<object> Events = new LinkedList<object>(); | |||
| protected ImmutableArray<object> Events = ImmutableArray<object>.Empty; | |||
There was a problem hiding this comment.
Protection from the racing conditions
|
Only one question left in comments. Beside that everything is fine. |
| /// <param name="destination">TBD</param> | ||
| /// <param name="message">TBD</param> | ||
| /// <param name="timestamp">TBD</param> | ||
| /// <param name="attempt">TBD</param> | ||
| public Delivery(ActorPath destination, object message, DateTime timestamp, int attempt) |
There was a problem hiding this comment.
This one will be internal in the next version, no need to have TBD docs