close #2581 - fixed PhiAccrualFailureDetector clock roll over #2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Apr 6, 2017
| // handle an edge case when the Clock rolls over | ||
| // see https://github.com/akkadotnet/akka.net/issues/2581 | ||
| [Fact] | ||
| public void PhiAccrualHistory_can_roll_over() |
|
|
||
| namespace Akka.Remote.Tests | ||
| { | ||
| public class PhiAccrualModelBasedSpecs |
There was a problem hiding this comment.
Added model-based test here just to make sure all of the math was being done correctly inside the PhiAccrualFailureDetector.
| /// <returns>TBD</returns> | ||
| public static readonly Clock DefaultClock = () => Environment.TickCount & Int32.MaxValue; | ||
| /// <returns>A clock instance.</returns> | ||
| public static readonly Clock DefaultClock = () => MonotonicClock.GetTicks(); |
There was a problem hiding this comment.
Key fix to the issue here. Switched to 64 bit timer instead of the previous 32bit implementation with Environment.TickCount.
20c69b5 to
01566b9
Compare
Aaronontheweb
commented
Apr 6, 2017
| var mean = history.Mean; | ||
| var stdDeviation = EnsureValidStdDeviation(history.StdDeviation); | ||
| return Phi(timeDiff, mean + AcceptableHeartbeatPauseMillis, stdDeviation); | ||
| unchecked // in the extremely rare event of a clock roll-over |
There was a problem hiding this comment.
Made this unchecked in the extremely rare event of a clock rollover. Realistically, this will never happen.
|
Deadline failure detector was using MS when it should have been using ticks, hence the failure. Fixed in latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.