Added more messages which ignores the serialization #2587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Apr 7, 2017
| @@ -408,21 +408,20 @@ private IInternalActorRef MakeChild(Props props, string name, bool async, bool s | |||
| { | |||
| if (argument != null && !(argument is INoSerializationVerificationNeeded)) | |||
| { | |||
| var objectType = argument.GetType(); | |||
There was a problem hiding this comment.
We were serializing the type of object, instead of object itself
alexvaluyskiy
commented
Apr 7, 2017
| { | ||
| var baseUserAction = (BaseClusterUserAction)obj; |
There was a problem hiding this comment.
This could cause an exception in some serializers
|
Merge conflicts with the most recent DData changes we pulled in |
689be15 to
738a1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've skipped the persistence