Revise TestActor used for EventsByPersistenceIdSpec to block until ack of Journal cleanup #2585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in response to a set of tests deemed flaky by TeamCity CI. Example here: http://petabridge-ci.cloudapp.net/viewLog.html?buildId=21833&tab=buildResultsDiv&buildTypeId=AkkaNet_AkkaPersistenceImplementations_AkkaPersistenceSqlServer_PrBuilds#testNameId-488764090331667693
Test failures were due to the
DeleteCommand
being sent to theTestActor
not completing the Journal cleanup before the assertions were being made against the cleaned-up Journal.Revised
TestActor
to send acknowledgement to TestKit actor only after it has received theDeleteMessagesSuccess
message back from the Journal. Also addedAwaitAssert
to wait for theExpectMsg("-deleted")
message or fail if not received within default timespan.