close #2570 - ported to Akka.Remote.TestKit to DotNetty #2574
Conversation
|
I had to disable some of the extra serialization and encoding logging we used to have with Helios since the DotNetty implementation of that stuff depends on implementing a bunch of gnarly Microsoft.Extensions.Logging stuff There's a pre-built package we can use but that requires a .NET Framework version runtime bump. I'm thinking we can add this back once we're on .NET Standard or 4.5.2 |
| /// that was given as zero. | ||
| /// </summary> | ||
| /// <returns>The address of the controller's socket endpoint</returns> | ||
| public Task<INode> SockAddr() |
There was a problem hiding this comment.
Have we used this method somewhere?
There was a problem hiding this comment.
Not since Akka.NET 1.1; it directly exposed old Helios 1.4* members to the public and stopped being used after we switched to Helios 2.0 last year.
|
Looks like this had some portability differences between the Helios 2.x and DotNetty APIs. Addressed those and added standard out logging back. |
|
Also added an additional spec that can run outside the MNTR to verify that |
|
Bah. Still need to prune the |
| <package id="Google.ProtocolBuffers" version="2.4.1.555" targetFramework="net45" /> | ||
| <package id="Helios" version="2.1.2" targetFramework="net45" /> | ||
| <package id="Microsoft.Extensions.DependencyInjection.Abstractions" version="1.1.0" targetFramework="net45" /> |
There was a problem hiding this comment.
Need to prune all of this crap out so it doesn't get pulled into the .nuspec metadata for Akka.Remote.TestKit as explicit dependencies.
|
LGTM |
No description provided.