Hide MatchHandler from the public API #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexvaluyskiy
commented
Mar 25, 2017
- Hide MatchHandler from the public API
- Added Xml comments to AutoReceive messages
- Enabled InternalVisibleTo for Persistence and for Streams
alexvaluyskiy
commented
Mar 25, 2017
| @@ -159,7 +159,7 @@ protected override void OnReplaySuccess() | |||
| /// <param name="receive">TBD</param> | |||
| /// <param name="message">TBD</param> | |||
| /// <returns>TBD</returns> | |||
| protected override bool AroundReceive(Receive receive, object message) | |||
| protected internal override bool AroundReceive(Receive receive, object message) | |||
There was a problem hiding this comment.
It is not affect a public API. But we need it if we want to enable [InternalVisibleTo] for this assembly
|
@alexvaluyskiy have a conflict with @sean-gilliam's PR |
39f752f to
4db85b6
Compare
Add InternalVisibleTo for Persistence and Streams Make MatchHandler internal
4db85b6 to
3034f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.