Stop ClusterClient ResponseTunnel after first reply when ask is used #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Mar 14, 2017
| c.Tell(new ClusterClient.Send("/user/service2", "bonjour4", localAffinity: true)); | ||
| var reply = ExpectMsg<ClusterClientSpecConfig.Reply>(10.Seconds()); | ||
| reply.Msg.Should().Be("bonjour4-ack"); | ||
| reply.Node.Should().Be(remainingContacts.First().Address); | ||
|
|
||
| // TODO: bug, cannot compare with a logsource | ||
| var logSource = $"{Sys.AsInstanceOf<ExtendedActorSystem>().Provider.DefaultAddress}/user/client4"; |
There was a problem hiding this comment.
Can't compare akka://MultiNodeClusterSpec/user/client4#723777256 with akka://MultiNodeClusterSpec/user/client4
b41da1a to
286cd48
Compare
3654ba6 to
8f24fb2
Compare
alexvaluyskiy
commented
Apr 2, 2017
| @@ -693,15 +695,15 @@ public sealed class CurrentTopics : IEquatable<CurrentTopics> | |||
| /// <summary> | |||
| /// TBD | |||
| /// </summary> | |||
| public string[] Topics { get; } | |||
| public IImmutableSet<string> Topics { get; } | |||
There was a problem hiding this comment.
It should be some type of Set, like in JVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.