Skip to content

add a test to demonstrate #2546 #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

add a test to demonstrate #2546 #2548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cd304d
add a test to demonstrate #2546
0x53A Mar 7, 2017
3f91e7f
possible fix for #2546: run TaskCompletionSource..TrySetResult on the…
0x53A Mar 8, 2017
f47e5f9
increase timeout for NBench from 25 minutes to 40 minutes
0x53A Mar 8, 2017
be02ca5
Merge branch 'dev' into demonstrate-deadlock
Aaronontheweb Sep 22, 2017
5d3f0e0
Merge branch 'dev' into demonstrate-deadlock
Danthar Sep 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/core/Akka.Remote.Tests/RemotingSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,20 @@ public async Task Remoting_must_support_Ask()
Assert.IsType<FutureActorRef>(msg.Item2);
}

[Fact]
public async Task Ask_does_not_deadlock()
{
// see https://github.com/akkadotnet/akka.net/issues/2546

// the configure await causes the continuation (== the second ask) to be scheduled on the HELIOS worker thread
var msg = await here.Ask<Tuple<string, IActorRef>>("ping", TimeSpan.FromSeconds(1.5)).ConfigureAwait(false);
Assert.Equal("pong", msg.Item1);

// the .Result here blocks the helios worker thread, deadlocking the whole system.
var msg2 = here.Ask<Tuple<string, IActorRef>>("ping", TimeSpan.FromSeconds(1.5)).Result;
Assert.Equal("pong", msg2.Item1);
}

[Fact]
public void Resolve_does_not_deadlock()
{
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka/Actor/ActorRef.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ protected override void TellInternal(object message, IActorRef sender)
{
if (Interlocked.Exchange(ref status, COMPLETED) == INITIATED)
{
_result.TrySetResult(message);
Task.Run(() => _result.TrySetResult(message));
}
}
}
Expand Down