fixes race condition with AskTimeoutSpec #2450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jan 13, 2017
| @@ -56,16 +56,24 @@ public AskTimeoutSpec() | |||
| var actor = Sys.ActorOf<SleepyActor>(); | |||
|
|
|||
| var actorCell = actor as ActorRefWithCell; | |||
| Assert.NotNull(actorCell); | |||
There was a problem hiding this comment.
Mostly to make ReSharper compiler warnings go away / throw the correct assertion error in the event that the underlying ActorCell is modified in a meaningful way in the future.
| @@ -826,7 +826,8 @@ public override IActorRef GetChild(IEnumerable<string> name) | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// TBD | |||
| /// Returns <c>true</c> if the <see cref="VirtualPathContainer"/> contains any children, | |||
There was a problem hiding this comment.
Filled in relevant comments.
| @@ -160,7 +160,7 @@ internal static IActorRefProvider ResolveProvider(ICanTell self) | |||
| timeoutCancellation.Cancel(); | |||
| timeoutCancellation.Dispose(); | |||
| } | |||
| for (int i = 0; i < ctrList.Count; i++) | |||
| for (var i = 0; i < ctrList.Count; i++) | |||
| container.ForEachChild(x => childCounter++); | ||
| Assert.True(childCounter==0,"Number of children in temp container should be 0."); | ||
| // Need to spin here, since the continuation function may not execute immediately | ||
| AwaitAssert(() => |
There was a problem hiding this comment.
Actual fix: the FutureActorRef is not unregistered from the VirtualPathContainer until after a continuation function has a chance to run, hence we need an AwaitAssert here in case that continuation hasn't been scheduled by the time we perform the assertion the first time around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2449