swapped out Wire references for Hyperion package #2421

Aaronontheweb · 2016-12-21T01:51:07Z

This PR swaps out the underlying Wire dependencies for Hyperion, in order to stop our users from getting GPL'd by upgrading to a new version of Wire.

I propose doing this across two releases

Release the current Akka.Serailization.Wire, complete with Hyperion dependencies, to move net new users onto the latest Hyperion version.
Deprecate the Akka.Serialization.Wire package and replace it with a Akka.Serialization.Hyperion package and update the necessary documentation in a subsequent release.

Any thoughts on the above?

Aaronontheweb · 2016-12-21T01:51:28Z

src/Akka.sln

@@ -186,7 +186,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.Serialization.Wire", "
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.Serialization.TestKit", "contrib\serializers\Akka.Serialization.TestKit\Akka.Serialization.TestKit.csproj", "{CAA97041-CFC0-4081-9BD2-8B139E62A611}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.Serialization.WireTests", "contrib\serializers\Akka.Serialization.WireTests\Akka.Serialization.WireTests.csproj", "{402FA351-D6C6-40FD-8868-F07156035919}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.Serialization.Wire.Tests", "contrib\serializers\Akka.Serialization.WireTests\Akka.Serialization.Wire.Tests.csproj", "{402FA351-D6C6-40FD-8868-F07156035919}"


Renamed the project so it would get picked up by our FAKE script for serialization purposes.

Aaronontheweb · 2016-12-21T01:52:02Z

src/core/Akka/Actor/Internal/ActorSystemImpl.cs

@@ -165,7 +165,7 @@ private void WarnIfJsonIsDefaultSerializer()
                Serialization.FindSerializerForType(typeof (object)) is NewtonSoftJsonSerializer)
            {
                Log.Warning($"NewtonSoftJsonSerializer has been detected as a default serializer. " +
-                            $"It will be obsoleted in Akka.NET starting from version 1.5 in the favor of Wire " +
+                            $"It will be obsoleted in Akka.NET starting from version 1.5 in the favor of Hyperion " +


Changed the message in our warning message, but we haven't updated the documentation that it points to currently.

sean-gilliam · 2016-12-21T02:06:04Z

Sounds good to me

Aaronontheweb · 2016-12-21T02:16:17Z

cc @Horusiath looks like we have an issue with the Akka.DistributedData bindings and the Hyperion serializer. Anything special that needs to be done with Hyperion or its serializer definition here? Take a look at the unit test failures. I can get them to fail locally as well.

Horusiath · 2016-12-21T08:00:49Z

@Aaronontheweb I think this is a result of changes made between Wire v0.7.1 and v0.8.1 - existing Akka.Serialization.Wire references the first, while Hyperion is based on the second.

It's one of the edge cases, we didn't have a test for - situation when immutable collection is referenced through interface (in this case IImmutableDictionary<,>) as a field in some custom class. I'll try to fix it today.

Aaronontheweb · 2016-12-21T16:04:24Z

@Horusiath thanks, we'll update the Hyperion package today

Aaronontheweb · 2017-01-03T21:55:08Z

Resolves #2435 as well

Horusiath · 2017-01-03T22:07:43Z

Failures in ddata are caused by the problem I've solved in akkadotnet/Hyperion#13 . Not sure if that fix is not a part of the latest Hyperion version.

Aaronontheweb · 2017-01-03T22:37:21Z

@Horusiath yep, that's all in there. Newest version of Hyperion is going up on NuGet now.

Aaronontheweb · 2017-01-04T00:01:16Z

Upgraded to 0.9.1

Aaronontheweb · 2017-01-04T00:34:30Z

@Horusiath still have 7 spec failures on the DistributedData stuff, down from 9. http://petabridge-ci.cloudapp.net/viewLog.html?buildId=18997&buildTypeId=AkkaNet_AkkaNetLinuxMonoUnitTests&guest=1

Horusiath · 2017-01-04T08:11:53Z

@Aaronontheweb I've pulled your PR and tracked down the issue. The problem lies here.

To deserialize enumerables (which ddata collections actually are), existing serializer was trying to find either AddRange or Add method and invoke it. Problem is that it automatically assumes, that signature of add method follows the rules:

void Add(T item)
void AddRange(IEnumerable<T> items)

...which is not true in case of ddata i.e. GSet<>.Add returns a whole new GSet instance (that's why test fails on assertion), while LWWDictionary<>.Add has different input params (that's why we have reflection exception).

Aaronontheweb · 2017-01-07T22:08:31Z

Found the issue:

[Test collection for Akka.Serialization.Wire.Tests.WireTests (1)] Akka.Serialization.Wire.Tests.WireTests.CanSerializeProps (4s)
[16:37:30]W:		 [docker] Stacktrace:
[16:37:30]W:		 [docker] 
[16:37:30]W:		 [docker]   at <unknown> <0xffffffff>
[16:37:30]W:		 [docker]   at (wrapper managed-to-native) System.RuntimeTypeHandle.type_is_assignable_from (System.Type,System.Type) <0x00057>
[16:37:30]W:		 [docker]   at System.RuntimeTypeHandle.CanCastTo (System.RuntimeType,System.RuntimeType) <0x00020>
[16:37:30]W:		 [docker]   at System.RuntimeType.IsAssignableFrom (System.Type) <0x000b6>
[16:37:30]W:		 [docker]   at Akka.Actor.Props.CreateProducer (System.Type,object[]) <0x0005d>
[16:37:30]W:		 [docker]   at Akka.Actor.Props..ctor (Akka.Actor.Deploy,System.Type,object[]) <0x00087>
[16:37:30]W:		 [docker]   at Akka.Actor.Props/PropsSurrogate.FromSurrogate (Akka.Actor.ActorSystem) <0x0005b>
[16:37:30]W:		 [docker]   at Akka.Serialization.WireSerializer/<WireSerializer>c__AnonStorey0.<>m__1 (Akka.Util.ISurrogate) <0x00025>
[16:37:30]W:		 [docker]   at Hyperion.Surrogate`2/<>c__DisplayClass0_0<TSource_REF, TSurrogate_REF>.<.ctor>b__1 (object) <0x00053>
[16:37:30]W:		 [docker]   at Hyperion.ValueSerializers.FromSurrogateSerializer.ReadValue (System.IO.Stream,Hyperion.DeserializerSession) <0x0003d>
[16:37:30]W:		 [docker]   at Hyperion.Serializer.Deserialize<T_REF> (System.IO.Stream) <0x00044>
[16:37:30]W:		 [docker]   at Akka.Serialization.WireSerializer.FromBinary (byte[],System.Type) <0x00063>
[16:37:30]W:		 [docker]   at Akka.Tests.Serialization.AkkaSerializationSpec.AssertEqual<T_REF> (T_REF) <0x0006d>
[16:37:30]W:		 [docker]   at Akka.Tests.Serialization.AkkaSerializationSpec.CanSerializeProps () <0x00077>
[16:37:30]W:		 [docker]   at (wrapper runtime-invoke) object.runtime_invoke_void__this__ (object,intptr,intptr,intptr) <0x000c8>
[16:37:30]W:		 [docker]   at <unknown> <0xffffffff>
[16:37:30]W:		 [docker]   at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&) <0x0006c>
[16:37:30]W:		 [docker]   at System.Reflection.MonoMethod.Invoke (object,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo) <0x000b7>
[16:37:30]W:		 [docker]   at System.Reflection.MethodBase.Invoke (object,object[]) <0x0002a>
[16:37:30]W:		 [docker]   at Xunit.Sdk.TestInvoker`1<TTestCase_REF>.CallTestMethod (object) <0x00043>

Looks like there's something going on in that assertion specifically that triggers a native error in the Mono runtime. Working on resolving some Mono build issues with Hyperion itself so I can get a better look.

Aaronontheweb · 2017-01-14T00:56:59Z

Trying this out with a Mono 4.6.1 build

Aaronontheweb · 2017-01-14T01:06:18Z

Looks like the Mono upgrade fixed the serialization issue.

Horusiath · 2017-01-14T09:05:26Z

Is it ready to merge?

Aaronontheweb · 2017-01-14T18:12:45Z

Yep

…

Sent from my iPhone

On Jan 14, 2017, at 1:05 AM, Bartosz Sypytkowski ***@***.***> wrote: Is it ready to merge? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Aaronontheweb commented Dec 21, 2016

View reviewed changes

Horusiath mentioned this pull request Dec 21, 2016

Fix for immutable interface calls and immutable stacks akkadotnet/Hyperion#13

Merged

swapped out Wire references for Hyperion package

0da1bbc

Aaronontheweb force-pushed the hyperion branch from 8cbcdb8 to 0da1bbc Compare January 4, 2017 00:00

upgraded to Hyperion v0.9.1

a7ea0f8

This was referenced Jan 4, 2017

Make stronger constraints on Enumerable factory akkadotnet/Hyperion#18

Closed

Stronger constraints on EnumerableSerializerFactory + tests akkadotnet/Hyperion#19

Merged

upgraded to Hyperion v0.9.2

def67f9

Aaronontheweb mentioned this pull request Jan 9, 2017

Continued work over Distributed Data #2441

Merged

Merge branch 'dev' into hyperion

982b42e

Horusiath added the reviewed positively label Jan 14, 2017

Horusiath merged commit 1963573 into akkadotnet:dev Jan 14, 2017

Aaronontheweb modified the milestone: 1.1.3 Jan 20, 2017

Aaronontheweb deleted the hyperion branch June 6, 2024 19:38

swapped out Wire references for Hyperion package #2421

swapped out Wire references for Hyperion package #2421

Uh oh!

Conversation

Aaronontheweb commented Dec 21, 2016

Uh oh!

Aaronontheweb Dec 21, 2016

Choose a reason for hiding this comment

Uh oh!

Aaronontheweb Dec 21, 2016

Choose a reason for hiding this comment

Uh oh!

sean-gilliam commented Dec 21, 2016

Uh oh!

Aaronontheweb commented Dec 21, 2016

Uh oh!

Horusiath commented Dec 21, 2016

Uh oh!

Aaronontheweb commented Dec 21, 2016

Uh oh!

Aaronontheweb commented Jan 3, 2017

Uh oh!

Horusiath commented Jan 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aaronontheweb commented Jan 3, 2017

Uh oh!

Aaronontheweb commented Jan 4, 2017

Uh oh!

Aaronontheweb commented Jan 4, 2017

Uh oh!

Horusiath commented Jan 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aaronontheweb commented Jan 7, 2017

Uh oh!

Aaronontheweb commented Jan 14, 2017

Uh oh!

Aaronontheweb commented Jan 14, 2017

Uh oh!

Horusiath commented Jan 14, 2017

Uh oh!

Aaronontheweb commented Jan 14, 2017 via email

Uh oh!

Uh oh!

Horusiath commented Jan 3, 2017 •

edited

Loading

Horusiath commented Jan 4, 2017 •

edited

Loading