Skip to content

Revert "Unregister temp actor if ask operation got canceled." #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2016
Merged

Revert "Unregister temp actor if ask operation got canceled." #2399

merged 1 commit into from
Dec 4, 2016

Conversation

Aaronontheweb
Copy link
Member

Reverts #2381

Have to revert this. Causes enormous, like hundreds of MBs worth of "unregister temp actor spam" in all of our logs. Can't ship it like this. Need to address that logging issue first.

@Aaronontheweb
Copy link
Member Author

See build log here for an example: http://petabridge-ci.cloudapp.net/viewLog.html?buildId=17864&buildTypeId=AkkaNet_AkkaNetWindowsPerformanceTests&tab=buildLog&guest=1

This is why this PR consistently failed its performance tests.

@Aaronontheweb Aaronontheweb merged commit 40b0c55 into dev Dec 4, 2016
@Aaronontheweb Aaronontheweb deleted the revert-2381-dev branch December 4, 2016 21:00
@Aaronontheweb
Copy link
Member Author

Example:

[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0010][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child qf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0010][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child rf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child sf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child tf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child uf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child vf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child wf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child xf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child yf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child zf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Af
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Bf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Cf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Df
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Ef
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Ff
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Gf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Hf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child If
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Jf
[20:45:35] :	 [Step 2/2] [WARNING][12/4/2016 8:45:35 PM][Thread 0008][LocalActorRefProvider(akka://MailboxThroughputSpecBase99)] akka://MailboxThroughputSpecBase99/temp trying to remove non-child Kf

@Aaronontheweb Aaronontheweb mentioned this pull request Dec 4, 2016
Closed
@Danthar
Copy link
Member

Danthar commented Dec 6, 2016

Aaah so thats why those log files went beyond their file size limit. Totally missed that, thought it was some kind of TC issue.

This was referenced Dec 16, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aaronontheweb @Danthar