Skip to content

Fix CircuitBreaker swallowing exceptions cased it to open #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2016
Merged

Fix CircuitBreaker swallowing exceptions cased it to open #2376

merged 1 commit into from
Nov 13, 2016

Conversation

andreyleskov
Copy link
Contributor

CircuitBreaker swallowing stack trace of exception cased it to become Open.
It makes debug harder

@andreyleskov andreyleskov changed the title CircuitBreaker does not swallow exception cased it to Open Fix CircuitBreaker swallowing exceptions cased it to open Nov 12, 2016
@Horusiath
Copy link
Contributor

@Aaronontheweb the only breaking thing is a racy test for cluster. Can we merge that anyway?

@Aaronontheweb
Copy link
Member

@Horusiath really weird that didn't work on the build server... I wonder why. Have to assume it's an issue with that VM size and Docker container being more sensitive to degrees of parallelism on that VM.

@Aaronontheweb Aaronontheweb merged commit df3c128 into akkadotnet:dev Nov 13, 2016
@Aaronontheweb
Copy link
Member

thanks for your help @andreyleskov !

@Aaronontheweb Aaronontheweb modified the milestone: 1.1.3 Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewed positively
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@andreyleskov @Horusiath @Aaronontheweb