Down if MemberStatus.Joining #2347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering how we can test this to ensure that it works.... |
|
Status on this one? The change itself looks good. @Aaronontheweb |
|
I think this one still needs a spec to verify that its behavior is inline with the cluster specifications |
|
resolved via #3551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull is intended to fix issue #2346.
I noticed that if a cluster member is in
Joiningstate when you callcluster.Leave(), the member will appear unreachable to other nodes indefinitely. This adds a check to see if the state isJoining, then callDowning()instead.The only caveat to this is that if you have a callback waiting on
cluster.RegisterOnMemberRemoved(someAction)then this won't be called. Is there some other event that should be hooked into for this?