Streams update to 2.4.5 #2303
Streams update to 2.4.5 #2303
Conversation
| @@ -20,7 +20,7 @@ public abstract class BaseTwoStreamsSetup<TOutputs> : AkkaSpec | |||
| { | |||
| protected readonly ActorMaterializer Materializer; | |||
|
|
|||
| public BaseTwoStreamsSetup(ITestOutputHelper output = null) : base(output) | |||
| protected BaseTwoStreamsSetup(ITestOutputHelper output = null) : base(output) | |||
There was a problem hiding this comment.
We have to add APISpec for Streams, because we could have public API breaking changes
|
LGTM |
|
@alexvaluyskiy it's not done yet, therefore the [WIP] ;) But I wanted some feedback regarding tests. |
dbecbb0 to
8c8c9ac
Compare
|
@alexvaluyskiy this is now ready for review |
| @@ -64,10 +64,8 @@ public void Select_should_not_blow_up_with_high_request_counts() | |||
|
|
|||
| var subscription = probe.ExpectSubscription(); | |||
| // TODO increase to 10000 once performance is improved | |||
| @@ -261,80 +261,6 @@ public void Interpreter_error_handling_should_fail_when_OnPull_throws() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Interpreter_error_handling_should_resume_when_Filter_throws() | |||
There was a problem hiding this comment.
Why this test was removed?
There was a problem hiding this comment.
These specs are moved into the corresponding DSL specs (FlowScanSpec, FlowWhereSpec...)
| @@ -122,7 +122,7 @@ public abstract class PushStage<TIn, TOut> : PushPullStage<TIn, TOut> | |||
| /// @see <see cref="PushPullStage{TIn,TOut}"/> | |||
| /// </summary> | |||
| [Obsolete("Please use GraphStage instead.")] | |||
| public abstract class DetachedStage<TIn, TOut> : AbstractStage<TIn, TOut, IUpstreamDirective, IDownstreamDirective, IDetachedContext<TOut>, ILifecycleContext> | |||
| public abstract class DetachedStage<TIn, TOut> : AbstractStage<TIn, TOut, IUpstreamDirective, IDownstreamDirective, IDetachedContext<TOut>> | |||
There was a problem hiding this comment.
Do we really need too many Obsoleted in a beta version?
There was a problem hiding this comment.
I'm not sure for this stage but in general we are still using these obsolete stages internally and will move to GraphStage over time. Once all stages are using GraphStage we can remove them.
|
@Silv3rcircl3 Could you rebase it please? |
8c8c9ac to
260dd08
Compare
|
@alexvaluyskiy rebased |
No description provided.