Skip to content

Moved Cluster.Sharding MNTK tests to a separate assembly #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2016
Merged

Moved Cluster.Sharding MNTK tests to a separate assembly #2304

merged 1 commit into from
Sep 12, 2016

Conversation

alexvaluyskiy
Copy link
Contributor

  • Moved Cluster.Sharding MNTK tests to a separate assembly
  • MNTK tests should run in a specific order: Remote -> Cluster -> ClusterTools -> Sharding

@alexvaluyskiy
Copy link
Contributor Author

@Aaronontheweb I've changed the order of MNTK tests, and the test from Cluster (LeaderElectionWithFailureDetectorPuppet) starts fail. So, It just random failing, doesn't related with Cluster.Tools or Cluster.

I've found this error

[ERROR][9/10/2016 8:28:13 AM][Thread 0021][akka://MultiNodeClusterSpec/system/log1-TestEventListener] Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
Cause: System.FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
   at System.Text.StringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.FormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.Format(String format, Object[] args)
   at Akka.Event.DefaultLogMessageFormatter.Format(String format, Object[] args) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Event\DefaultLogMessageFormatter.cs:line 23
   at Akka.Event.LogMessage.ToString() in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Event\LogMessage.cs:line 42
   at System.Text.StringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.FormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.Format(String format, Object[] args)
   at Akka.Event.LogEvent.ToString() in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Event\LogEvent.cs:line 65
   at Akka.Event.StandardOutLogger.PrintLogEvent(LogEvent logEvent) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Event\StandardOutLogger.cs:line 132
   at Akka.Event.DefaultLogger.Print(LogEvent logEvent) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Event\DefaultLogger.cs:line 39
   at Akka.TestKit.TestEventListener.Receive(Object message) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka.TestKit\EventFilter\TestEventListener.cs:line 61
   at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Actor\ActorBase.cs:line 154
   at Akka.Actor.ActorCell.ReceiveMessage(Object message) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Actor\ActorCell.DefaultMessages.cs:line 168
   at Akka.Actor.ActorCell.Invoke(Envelope envelope) in D:\BuildAgent\work\d26c9d7f36545acd\src\core\Akka\Actor\ActorCell.DefaultMessages.cs:line 77

I've seen this error before... in Cluster.Tools tests

@alexvaluyskiy alexvaluyskiy changed the title Moved Cluster.Sharding MNTK tests to a separate assembly [WIP] Moved Cluster.Sharding MNTK tests to a separate assembly Sep 10, 2016
@alexvaluyskiy alexvaluyskiy force-pushed the multinodetweak branch 2 times, most recently from dfb6fca to c1b9903 Compare September 11, 2016 11:10
alexvaluyskiy
alexvaluyskiy reviewed Sep 11, 2016
View reviewed changes
build.fsx
mkdir testOutput
let multiNodeTestPath = findToolInSubPath "Akka.MultiNodeTestRunner.exe" "bin/core/Akka.MultiNodeTestRunner*"
let multiNodeTestAssemblies = !! testSearchPath
let multiNodeTestAssemblies = !! "src/**/bin/Release/Akka.Remote.Tests.MultiNode.dll" ++
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run MNTK tests in a specific order: Remote -> Cluster -> ClusterTools

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the sharding tests to this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise I agree with the change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharding tests are not work at the moment. We could enable them later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They just exist

@alexvaluyskiy alexvaluyskiy changed the title [WIP] Moved Cluster.Sharding MNTK tests to a separate assembly Moved Cluster.Sharding MNTK tests to a separate assembly Sep 11, 2016
Aaronontheweb
Aaronontheweb reviewed Sep 11, 2016
View reviewed changes
src/core/Akka.Remote.TestKit/Player.cs
@@ -402,7 +402,7 @@ public void InitFSM()
{
if (@event.StateData.RunningOp == null)
{
_log.Warning("did not expect {1}", @event.FsmEvent);
_log.Warning("did not expect {0}", @event.FsmEvent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be the fix for the bug you reported

@Aaronontheweb Aaronontheweb merged commit dd04740 into akkadotnet:dev Sep 12, 2016
@Aaronontheweb Aaronontheweb modified the milestone: 1.1.2 Sep 21, 2016
@alexvaluyskiy alexvaluyskiy deleted the multinodetweak branch June 27, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvaluyskiy @Aaronontheweb