add support for non abbreviated timespan strings #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of test failures.... |
|
@mrrd it looks like you broke the parsing of normal values ? A quick survey reveales that values like: 0.05 s are causing problems now. Check the remote conf for more samples: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Remote/Configuration/Remote.conf I think if you fix those scenario's it should probably resolve most, if not all, failing unit tests. |
|
@Danthar thanks I can see exactly what I have missed a + in the regex |
fix the regular expression to account for more than a single digit after the decimal point
fix the regular expression to account for more than a single digit after the decimal point fix test change brackets to Allman style change brackets to Allman style update failing test
…kka.net into feature/hocon-gettimespan
|
@mrrd can you please squash your commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for non abbreviated timespan values in hocon