Check for empty message in Envelope class #2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var manifestSerializer = serializer as SerializerWithStringManifest; | ||
| if (manifestSerializer != null) | ||
| { | ||
| var manifest = manifestSerializer.Manifest(serialized); | ||
| message = _systemImpl.Serialization.Deserialize(serialized, manifestSerializer.Identifier, manifest); | ||
| message = new Envelope(_systemImpl.Serialization.Deserialize(serialized, manifestSerializer.Identifier, manifest), message.Sender); |
There was a problem hiding this comment.
Scala version has a bit different implementation
https://github.com/akka/akka/blob/4acc1cca6a27be0ff80f801de3640f91343dce94/akka-actor/src/main/scala/akka/actor/dungeon/Dispatch.scala#L138
I should check for null, and then throw an exception
| @@ -101,6 +101,7 @@ namespace Akka.Actor | |||
| public void ReserveChild(string name) { } | |||
| public void Restart(System.Exception cause) { } | |||
| public void Resume(System.Exception causedByFailure) { } | |||
| public virtual void SendMessage(Akka.Actor.Envelope message) { } | |||
There was a problem hiding this comment.
Do we need this? Why not have the other SendMessage method construct the envelope?
There was a problem hiding this comment.
I did the same what Akka JVM has
| @@ -296,7 +296,7 @@ public void UseThreadContext(Action action) | |||
| } | |||
| } | |||
|
|
|||
| public virtual void SendMessage(IActorRef sender, object message) | |||
| public virtual void SendMessage(Envelope message) | |||
| { | |||
| if (Mailbox == null) | |||
There was a problem hiding this comment.
What is that? Akka JVM doesn't have this check
| { | ||
| var manifest = manifestSerializer.Manifest(unwrapped); | ||
| var deserialized = _systemImpl.Serialization.Deserialize(serialized, serializer.Identifier, manifest); | ||
| message = new Envelope(deserialized, message.Sender); |
There was a problem hiding this comment.
Some tests don't work without this. But scala code doesn't have this assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also removed all getters in the properties