Align SupervisorStrategy with scala version #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexvaluyskiy
commented
Jul 27, 2016
- added an abstract IDecider property to an abstract SupervisorStrategy class
- added "child" parameter to ProcessFailure method
4bde982 to
0e3fd7c
Compare
| @@ -385,7 +385,7 @@ private void FinishRecreate(Exception cause, ActorBase failedActor) | |||
| var statsUid = childStats.Child.Path.Uid; | |||
| if (statsUid == f.Uid) | |||
| { | |||
| var handled = _actor.SupervisorStrategyInternal.HandleFailure(this, f.Cause, childStats, ChildrenContainer.Stats); | |||
| var handled = _actor.SupervisorStrategyInternal.HandleFailure(this, failedChild, f.Cause, childStats, ChildrenContainer.Stats); | |||
There was a problem hiding this comment.
I don't like this part. Why not just _actor.SupervisorStrategy?
0e3fd7c to
6ef4e98
Compare
|
@akkadotnet/core ready for review |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.