meta-table-name replaced with metadata-table-name #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple config file values were in use for the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Persistence.Sql.Common code and sqlite.conf referred to a variable called metadata-table-name. SqliteJournal.cs and many unit tests referred to meta-table-name.
The unit tests passed before because the default value of metadata-table-name in sqllite.conf plus their manually configured meta-table-name variables defined in test worked out to cover both cases (and set them to the same name), but if you were to create a new project and assume the default name would cover all bases, you'd be wrong. To get a sqlite persistence working in a new app I found I had to set both metadata-table-name and meta-table-name to the same value to get things to work. Out of the box, following the sqlite modules directions, the sqlite persistence engine would not work right.
This PR standardizes all places to use metadata-table-name, as that is what the core persistence module uses and is what is set by default by sqlite.conf. This should allow someone to use the sqlite persistence module with no error out of the box.