fix for DNS resolution issues #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,12 +69,13 @@ public HeliosTransportDnsResolutionSpec() | |||
| Arb.Register(typeof(EndpointGenerators)); | |||
| } | |||
|
|
|||
| public Config BuildConfig(string hostname, int? port = null, string publichostname = null) | |||
| public Config BuildConfig(string hostname, int? port = null, string publichostname = null, bool useIpv6 = false) | |||
There was a problem hiding this comment.
Modified to use configurable IP version with DNS resolution
d99e92e to
66740f7
Compare
| { | ||
| return ConfigurationFactory.ParseString(@"akka.actor.provider = ""Akka.Remote.RemoteActorRefProvider, Akka.Remote""") | ||
| .WithFallback("akka.remote.helios.tcp.hostname =\"" + hostname + "\"") | ||
| .WithFallback("akka.remote.helios.tcp.public-hostname =\"" + (publichostname ?? hostname) + "\"") | ||
| .WithFallback("akka.remote.helios.tcp.port = " + (port ?? 0)) | ||
| .WithFallback("akka.remote.helios.tcp.dns-use-ipv6 = " + useIpv6.ToString().ToLowerInvariant()) |
There was a problem hiding this comment.
DNS resolution switch from configuration
…made it configurable via HOCON.
66740f7 to
4987e29
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2161
upgraded to Helios 2.1.2; set default DNS resolution target to IPV4; made DNS resolution configurable via HOCON.