Fix a bug that handled DeadLetters are published. #2159
Conversation
DeadLetterActorRef.TellInternal should process DeadLetter like [ActorRef.scala]( https://github.com/akka/akka/blob/60fb163331aa2f9c22e27a9fc424f5975bc45d13/akka-actor/src/main/scala/akka/actor/ActorRef.scala#L582).
|
I have the same changes here |
|
@Aaronontheweb @veblush PoisonPill marked as IDeadLetterSupression. But the message never going through this method. I know, that we are sending NoSender, which equals null, but how is it works in Scala? And why I got this error in DeadLetter constructor instead of SupressedDeadLetter? |
|
@alexvaluyskiy do you have a stacktrace for that error? |
| if(d != null && !SpecialHandle(d.Message, d.Sender)) { _eventStream.Publish(d); | ||
| if (d != null) | ||
| { | ||
| if (!SpecialHandle(d.Message, d.Sender)) { _eventStream.Publish(d); } |
There was a problem hiding this comment.
How is this any different than what we had before?
DeadLetterActorRef.TellInternal should process DeadLetter like ActorRef.scala. Without this fix,
Watchsent to already stopped actor will publish unncessaryDeadLetterevent.