Remove an unnecessary DeadLetter at GracefulStop. #2157 #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@veblush Looks good, but, It is a bad idea to change standard Scala specs if we want to verify a new bug. The better idea is - create a new test with name like "GracefulStopSupport_must_not_send_unnecessary_Deadletter_bug_2157" |
|
@veblush I agree with @alexvaluyskiy. Could you revert the original spec to as it was and then add a new spec to that file, as @alexvaluyskiy suggested? |
|
Oh good point. I didn't know that. I'll take it. |
|
Oh i failed to update this PR to have squash one commit. I create new PR and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.