added missing copyright headers; added spec to verify joining when a seed node is offline #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| #### 1.0.9 April 26 2016 #### | |||
There was a problem hiding this comment.
Ignore. Going to replace in a subsequent commit.
| /// Tests to ensure that if we have 2 seed nodes defined and 1 is offline during a <see cref="Cluster.JoinSeedNodes"/> | ||
| /// command, the joining node will still be marked as <see cref="MemberStatus.Up"/> as long as there are no unreachable nodes | ||
| /// within the cluster. | ||
| /// </summary> |
There was a problem hiding this comment.
Comment explains the purpose of this spec - tests a common scenario where only 1 seed node needs to be Up in order for a cluster to be joined. Other previous seed nodes can be Downed / offline and the join will still go through correctly.
…seed node is offline
eb71cd1 to
04e4dc5
Compare
|
URL is still http://www.typesafe.com, will create another PR to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.