disabled Helios STDOUT logging; eliminated ERROR logs for shutdown associations #2135
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reason.Match().With<EndpointDisassociatedException>(endpoint => PublishDisassociated()) | ||
| reason.Match() | ||
| .With<EndpointDisassociatedException>(endpoint => PublishDisassociated()) | ||
| .With<ShutDownAssociation>(shutdown => {}) // don't log an error for planned shutdowns |
There was a problem hiding this comment.
This is not present in the JVM, but I think it may be a good idea. Basically we won't log disassociations that occur as part of a shutdown (planned termination) as errors. Disabling logging for this since we get a steady drumbeat of questions from developers who are worried they're doing something wrong after seeing this error. Since the answer is "no, you're not doing anything wrong" I figured we may as well not log it as an exception to avoid the uncertainty.
The shutdown association gets logged as a DEBUG message by the EndpointManager after this, so it will still appear in the log files.
1da5f4e to
e76ac9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some logging cleanup before we push 1.1