Implemented DeterministicOldestWhenJoiningSpec #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can reset the git timestamp using this technique: http://stackoverflow.com/a/31540373/377476 - that way CI can pick up the commit and run. |
ee816e7 to
9b3e442
Compare
|
Take a look at the failed cluster domain event specs in the unit tests - looks like there are some issues there. |
f976786 to
6e74ae1
Compare
|
@alexvaluyskiy have you tried rebasing this with your latest changes yet? |
|
Yep, no changes |
de0495b to
736e444
Compare
736e444 to
6b755cd
Compare
|
@Aaronontheweb ready for review |
|
@alexvaluyskiy got it! |
| Joining_cluster_must_result_in_deterministic_oldest_node(); | ||
| } | ||
|
|
||
| public void Joining_cluster_must_result_in_deterministic_oldest_node() |
|
Solid work. The changes make sense to me - I'll pull this into my work on the transition spec as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2082
Should go after these two: #2098 and #2099