Naming conventions #1935
Merged
Naming conventions #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,7 @@ public void Conflate_must_work_with_a_buffer_and_fold() | |||
| Source.From(Enumerable.Range(1, 50)) | |||
| .ConflateWithSeed(i => i, (sum, i) => sum + i) | |||
| .Buffer(50, OverflowStrategy.Backpressure) | |||
| .RunFold(0, (sum, i) => sum + i, Materializer); | |||
| .RunAggregate(0, (sum, i) => sum + i, Materializer); | |||
There was a problem hiding this comment.
Method name should be Conflate_must_work_with_a_buffer_and_aggregate
|
|
||
| [Fact] | ||
| public void A_Reduce_must_work_when_using_Source_RunReduce() | ||
| public void A_Sum_must_work_when_using_Source_RunReduce() |
There was a problem hiding this comment.
Should be A_Sum_must_work_when_using_Source_RunSum
|
Maybe it would make sense to keep the corresponding jvm file name as comment in renamed test files? |
|
Yes it would make sense. |
|
@Silv3rcircl3 updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Akka.Stream DSL naming conventions to closer match LINQ/RxNet: