Removed dependency on Newtonsoft.Json in F# serialization and persistence #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match Serialization.tryDeserializeJObject serializer.Serializer msg with | ||
| | Some(e) -> state <- aggregate.apply mailbox state e | ||
| | None -> x.Unhandled msg | ||
| let serializer = UntypedActor.Context.System.Serialization.FindSerializerForType typeof<obj> |
There was a problem hiding this comment.
Shouldn't that be typeof<'Event>?
|
I thought so too, that is should use concrete types instead of obj. But since I am new to the code base I wanted to be very conservative about changes and left the original code untouched as much as I could. But now that you pointed this out - yes I agree. It should be the actual types - 'Event, 'Command etc. |
|
Corrected type cast. |
|
It looks like we have some FAKE problems. /cc @Aaronontheweb |
|
@object you need to rebase with latest dev, that should fix the build problems |
|
Will do, thanks. |
Added some basic specs for the mailbox/actor combinations in Akka.NET. Bounded dispatcher and mailbox configurations haven't been added yet as these are not supported right now. Takes care of issue #1793
|
@Silv3rcircl3 @Horusiath I rebased my changes, should be OK now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes a bit in the blind because there don't seem to be any tests that trigger the affected code. All F# API tests pass, and I verified that the sample program PersistenceExample.FsApi work just as it worked before. Now it works with both JSON.NET and Wire serializer, before F# persistence wrapper expected only JSON.NET. But even using PersistenceExample.FsApi I was not able to test all code branches.
If you find something that doesn't work with the proposed changes, please let me know how I can reproduce the problem and I will try to fix it.