Fix IndexOf() method for concatenated byte strings #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| get | ||
| { | ||
| if (!IsEmpty) return _array[_offset]; | ||
| return default(T); |
There was a problem hiding this comment.
I think head should throw if the list is empty, I would expect the same behavior as with First. Also suggests the name offset that it could throw indexoutofrange even if the list isn't empty, offset >= count
|
Thanks for reviewing. Will revert that part and see if there's a better way to solve the problem. |
Fixes issue #1852 where the method IndexOf(x) for a concatenated set of byte strings would throw an index out of range exception when the element doesn't exist in the either one of the strings.
|
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1852 where the method IndexOf(x) for a concatenated set
of byte strings would throw an index out of range exception when the
element doesn't exist in the either one of the strings.
Included two tests to confirm that existing and non-existing element situations work.