Skip to content

Recovered default journal & snapshot store to default config #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2016
Merged

Recovered default journal & snapshot store to default config #1864

merged 1 commit into from
Apr 10, 2016

Conversation

Horusiath
Copy link
Contributor

See #1861

  • Default config journal plugin id is restored to point at in-memory journal (was none, causing an error).
  • Default config snapshot store plugin id is restored to point at local file system one (was none with warning log message, which didn't cause any explicit error, but was breaking change in API behavior).

EDIT:

  • All persistence specs are now running on default config settings, making sure that default journal and snapshot store have been initialized.

@Aaronontheweb
Copy link
Member

Can we get spec coverage for this as well?

@Horusiath Horusiath force-pushed the persistence-config-fix branch from 2c7fc90 to 7f7d976 Compare April 9, 2016 05:23
@Horusiath Horusiath force-pushed the persistence-config-fix branch from 7f7d976 to 5226f23 Compare April 10, 2016 08:34
@Horusiath
Copy link
Contributor Author

Tests for default journal and snapshot store included.

@Aaronontheweb
Copy link
Member

Thank you sir

@Aaronontheweb Aaronontheweb merged commit 25a1ede into akkadotnet:dev Apr 10, 2016
This was referenced Apr 26, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
akka-persistence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Horusiath @Aaronontheweb