Added support for DateTimeOffset as a primitive #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JessieWadman I think, you could go straightforward and serialize it as combination of DateTime part as ticks (one long) and TimeSpan offset ticks (another long). This will save possible problems in the future. |
|
@Horusiath You mean in case someone decides to create a DateTimeOffset with +40 hours or something? |
|
@JessieWadman I'm thinking here more about time zone component used with precision to milliseconds or less. |
|
You're right, of course. As far as I know, all time zones are expressed in hours only, with the exception of three(?) that are some hours and 30 or 45 minute offset. Nevertheless, since the DateTimeOffset structure can express offset in ticks, it's not for us to misplace those along the way. |
This was referenced Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles DateTimeOffset as a primitive, the same way as DateTime is currently handled. It serializes the offset in minutes, instead of DateTimeKind. The offset can be +/- 720 minutes, so a signed short has been used.