Skip to content

feat: Add LatestEventTimestampQuery #32700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat: Add LatestEventTimestampQuery #32700

merged 1 commit into from
Apr 14, 2025

Conversation

patriknw
Copy link
Contributor

  • Retrieve the latest timestamp for an entity type and slice range.
  • Primary purpose is for observability.

@patriknw
feat: Add LatestEventTimestampQuery
82483e1 
* Retrieve the latest timestamp for an entity type and slice range.
* Primary purpose is for observability.
This was referenced Apr 11, 2025
Merged
Merged
@pvlugter pvlugter mentioned this pull request Apr 14, 2025
Merged
pvlugter
pvlugter approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add an equivalent for durable state? Or we could make it a shared interface — it's only Event in the name that would be different.

@patriknw
Copy link
Contributor Author

I think that would have to be a separate interface which extends DurableStateStore. Let's wait with that until we have real demand for that. Probably not that important with lag observability for durable state since it only needs the latest change, and not full catch up.

@pvlugter
Copy link
Member

Probably not that important with lag observability for durable state since it only needs the latest change, and not full catch up.

Right. But if we want to be able to detect stalled projections on durable state entities in the same way.

ennru
ennru approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit cc7862b into main Apr 14, 2025
5 checks passed
@ennru ennru deleted the wip-latest-offset-patriknw branch April 14, 2025 11:31
@patriknw patriknw added this to the 2.10.4 milestone Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvlugter pvlugter pvlugter approved these changes

@ennru ennru ennru approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@patriknw @pvlugter @ennru @johanandren