Skip to content

docs: Shutdown hook in logback config sample to not lose async #32688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

docs: Shutdown hook in logback config sample to not lose async #32688

merged 1 commit into from
Mar 31, 2025

Conversation

johanandren
Copy link
Contributor

@johanandren johanandren commented Mar 31, 2025 •
edited
Loading

The async appender may not have time to emit entries logged just before the JVM exits without this.

octonato
octonato approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato octonato merged commit 9228b45 into main Mar 31, 2025
5 checks passed
@octonato octonato deleted the wip-docs-include-logback-shutdown-hook branch March 31, 2025 21:47
@octonato octonato added this to the 2.10.3 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@johanandren @octonato