Skip to content

build: avoid sbt deprecation warning for ValidatePullRequest imports #32637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

build: avoid sbt deprecation warning for ValidatePullRequest imports #32637

merged 1 commit into from
Feb 11, 2025

Conversation

sebastian-alfers
Copy link
Contributor

Before this change, I see the following warnings when starting sbt:

[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:26:27: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]   override def requires = ValidatePullRequest
[warn]                           ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:42:5: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     validatePullRequest / includeFilter := PathGlobFilter("akka-*/**"),
[warn]     ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:42:44: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     validatePullRequest / includeFilter := PathGlobFilter("akka-*/**"),
[warn]                                            ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:43:5: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     validatePullRequestBuildAll / excludeFilter := PathGlobFilter("project/MiMa.scala"),
[warn]     ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:43:52: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     validatePullRequestBuildAll / excludeFilter := PathGlobFilter("project/MiMa.scala"),
[warn]                                                    ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:44:5: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     prValidatorGithubRepository := Some("akka/akka"),
[warn]     ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:45:5: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]     prValidatorTargetBranch := "origin/main")
[warn]     ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:56:7: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]       prValidatorTasks := Seq(ValidatePR / test) ++ additionalTasks.value,
[warn]       ^
[warn] /Users/alf/dev/sebastian-alfers/akka/project/ValidatePullRequest.scala:57:7: value ValidatePullRequest in package sbt is deprecated (since 2.0.0): com.github.sbt.pullrequestvalidator.ValidatePullRequest
[warn]       prValidatorEnforcedBuildAllTasks := Seq(Test / test) ++ additionalTasks.value)
[warn]       ^
[warn] one feature warning; re-run with -feature for details
[warn] 10 warnings found

johanandren
johanandren approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as easy as that 👍

@octonato octonato merged commit 4c570f9 into akka:main Feb 11, 2025
5 checks passed
@octonato octonato added this to the 2.10.2 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octonato octonato octonato approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastian-alfers @octonato @johanandren