-
Notifications
You must be signed in to change notification settings - Fork 3.6k
docs: revise URL structure (libraries, akka-core) #32518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
### Migrating from PersistentFSM to EventSourcedBehavior | ||
|
||
If you've migrated from `PersistentFSM` to `EventSourcedBehavior` (See the [Akka 2.8 migration guide](https://doc.akka.io/docs/akka/2.8/persistence-fsm.html#migration-to-eventsourcedbehavior)) | ||
If you've migrated from `PersistentFSM` to `EventSourcedBehavior` (See the [Akka 2.8 migration guide](https://doc.akka.io/libraries/akka/2.8/persistence-fsm.html#migration-to-eventsourcedbehavior)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libraries/akka-core/ here, or is there is a reason for keeping the old versions as libraries/akka/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking "change as little as possible", but don't have a strong opinion. This PR only updates links to current
(thus future) versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems more difficult to keep track of different links for before and after a certain point. since we are anyway adding redirects (or symlinks) I think it's better to change all of them
@@ -31,7 +31,7 @@ Key links: | |||
### Check availability | |||
|
|||
- [ ] Check [API](https://doc.akka.io/api/akka/$VERSION$/) documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what abaout api and japi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they can stay as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I now think you mean akka-core for api and japi. Right. That should change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updating URLs for the upcoming release train.