Skip to content

docs: revise URL structure (libraries, akka-core) #32518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

ennru
Copy link
Contributor

@ennru ennru commented Sep 20, 2024

Updating URLs for the upcoming release train.


### Migrating from PersistentFSM to EventSourcedBehavior

If you've migrated from `PersistentFSM` to `EventSourcedBehavior` (See the [Akka 2.8 migration guide](https://doc.akka.io/docs/akka/2.8/persistence-fsm.html#migration-to-eventsourcedbehavior))
If you've migrated from `PersistentFSM` to `EventSourcedBehavior` (See the [Akka 2.8 migration guide](https://doc.akka.io/libraries/akka/2.8/persistence-fsm.html#migration-to-eventsourcedbehavior))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libraries/akka-core/ here, or is there is a reason for keeping the old versions as libraries/akka/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking "change as little as possible", but don't have a strong opinion. This PR only updates links to current (thus future) versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems more difficult to keep track of different links for before and after a certain point. since we are anyway adding redirects (or symlinks) I think it's better to change all of them

@@ -31,7 +31,7 @@ Key links:
### Check availability

- [ ] Check [API](https://doc.akka.io/api/akka/$VERSION$/) documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what abaout api and japi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe they can stay as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I now think you mean akka-core for api and japi. Right. That should change.

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants