use right youngest when moving to Up, #23582 #23596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also confirm TakeOverFromMe when singleton already in oldest state
|
Test PASSed. |
raboof
approved these changes
Sep 4, 2017
| def validNodeForGossip(node: UniqueAddress): Boolean = | ||
| node != selfUniqueAddress && | ||
| ((isInSameDc(node) && isReachableExcludingDownedObservers(node)) || | ||
| // if cross DC we need to check pairwise unreachable observation | ||
| overview.reachability.isReachable(selfUniqueAddress, node)) | ||
|
|
||
| def youngestMember: Member = { | ||
| val mbrs = membersInSameDc |
There was a problem hiding this comment.
👍 neat to move that here (and take into account dc)
| case Event(TakeOverFromMe, _) ⇒ | ||
| // already oldest, so confirm and continue like that | ||
| sender() ! HandOverToMe | ||
| stay |
|
I'm merging this quickly since it's failing often. I will not close the ticket yet. I think there might be more things. Have to look at more logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #23582