deferAsync adds cases with persist, not only persistAsync #22450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
I think this is good, more examples is more helpful in this case I think, since people may easily get confused what would happen etc. Happy to accept this PR as is without removing the other examples 👍 |
ktoso
approved these changes
Mar 3, 2017
|
Hahaha you are Akka-chan now. Thank you very much for the review. |
5dc73b1 to
36798b3
Compare
|
Test PASSed. |
|
Synced up with master |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #20873
As in the above referenced issue, I wanted to remove the test cases ([1], [2]) of the mixed use
persist/persistAsynccases, but I did not. Please let me know if I can remove them, then I wil update the commit.DOC (Scala, Java) , BEFORE
AFTER
and I added a new code sample with
persistfollowing the//order of received messages:sample.