#22136 - Wraps CombinedReadEventAdapter into NoopWriteEventAdapter #22137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple event-adapters are configured they are combined into a single instance of `CombinedReadEventAdapter`.
However `CombinedReadEventAdpater` is not just a `ReadEventAdapter` but a full `EventAdapter`
which throws an `IllegalStateException("CombinedReadEventAdapter must not be used when writing (creating manifests) events!")`
when its `toJournal` method is called.
The `CombinedReadEventAdapter` is not wrapped into `NoopWriteEventAdapter` (because it's not a `ReadEventAdapter`)
and therefore it doesn't avoid the `toJournal` calls.
This is especially problematic when multiple `ReadEventAdapter` are combined together as illustrated in the new testcase.
|
Hi @by-dam, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Can one of the repo owners verify this patch? |
|
CLA accepted |
|
OK TO TEST |
|
PLS BUILD |
|
PLS BUILD |
|
Test FAILed. |
|
It doesn't look like a test failure but a credential issue with ssh |
|
ok, let's rebuild |
|
PLS BUILD |
|
Still the same issue: |
|
Test PASSed. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for reported issue #22136
When multiple event-adapters are configured they are combined into a single instance of
CombinedReadEventAdapter.However
CombinedReadEventAdpateris not just aReadEventAdapterbut a fullEventAdapterwhich throws an
IllegalStateException("CombinedReadEventAdapter must not be used when writing (creating manifests) events!")when its
toJournalmethod is called.The
CombinedReadEventAdapteris not wrapped intoNoopWriteEventAdapter(because it's not aReadEventAdapter) and therefore it doesn't avoid thetoJournalcalls.This is especially problematic when multiple
ReadEventAdapterare combined together as illustrated in the new testcase.