Skip to content

send terminationMessage to singleton when leaving last, #21592 #21654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2016
Merged

send terminationMessage to singleton when leaving last, #21592 #21654

merged 2 commits into from
Oct 28, 2016

Conversation

patriknw
Copy link
Contributor

  • When leaving last node, i.e. no newOldestOption, the manager was
    just stopped. The change is to send the terminationMessage also
    in this case and wait until the singleton actor is terminated
    before stopping the manager.
  • Also changed so that the singleton is stopped immediately when
    cluster has been terminated when last node is leaving, i.e.
    no newOldestOption. Previously it retried until maxTakeOverRetries
    before stopping.
  • More comprehensive test of this scenario in ClusterSingletonManagerLeaveSpec

@patriknw
send terminationMessage to singleton when leaving last, #21592
2bd13a1 
* When leaving last node, i.e. no newOldestOption, the manager was
  just stopped. The change is to send the terminationMessage also
  in this case and wait until the singleton actor is terminated
  before stopping the manager.
* Also changed so that the singleton is stopped immediately when
  cluster has been terminated when last node is leaving, i.e.
  no newOldestOption. Previously it retried until maxTakeOverRetries
  before stopping.
* More comprehensive test of this scenario in ClusterSingletonManagerLeaveSpec
@patriknw
Copy link
Contributor Author

Refs #21592

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Oct 12, 2016
@akka-ci
Copy link

akka-ci commented Oct 12, 2016

Test FAILed.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Oct 12, 2016
@akka-ci
Copy link

akka-ci commented Oct 12, 2016

Test PASSed.

johanandren
johanandren approved these changes Oct 12, 2016
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff!

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Oct 27, 2016
@ktoso
Copy link
Contributor

ktoso commented Oct 28, 2016

LGTM, was just reviewing when you pinged on gitter @patriknw ;-)

@ktoso ktoso merged commit 9be7df1 into master Oct 28, 2016
@ktoso ktoso deleted the wip-21592-singleton-leave-patriknw branch October 28, 2016 12:23
@alexvaluyskiy alexvaluyskiy mentioned this pull request Feb 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patriknw @akka-ci @ktoso @johanandren