Higher recovery timeout in PersistentActorRecoveryTimeoutSpec #21445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ object PersistentActorRecoveryTimeoutSpec { | |||
| SteppingInmemJournal.config(PersistentActorRecoveryTimeoutSpec.journalId).withFallback( | |||
| ConfigFactory.parseString( | |||
| """ | |||
| |akka.persistence.journal.stepping-inmem.recovery-event-timeout=100ms | |||
| |akka.persistence.journal.stepping-inmem.recovery-event-timeout=500ms | |||
There was a problem hiding this comment.
what happens if you make it even longer? will that slow down the test too much?
There was a problem hiding this comment.
That's what I was thinking, but it's just a single negative test case so maybe a second wouldn't hurt too much.
|
LGTM |
e4fd19c to
72760cc
Compare
|
Test PASSed. |
|
Test PASSed. |
|
LGTM |
1 similar comment
|
LGTM |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not fail on slow/gc
Fixes #20728