Skip to content

Conversation

richardimaoka
Copy link
Contributor

Although #20394 suggested below, I think dupe persistentId can only be detected in ReplayFilter.

A better solution would be to detect the problem when the it first arises

Detecting dupe when:

  • persistent actor is instantiated -> impossible, no global registry of persistentIds
  • an event is journaled -> impossible, journals don't perform validation on persistentId
  • ReplayFilter is called -> possible, but it needs to be turned on (mode != off)

However, the modified error messages got long because (partially my bad :| please suggest if they can be shorter) as we cannot be exact whether errors are from dupe persistentId or not.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Sep 9, 2016
@akka-ci
Copy link

akka-ci commented Sep 9, 2016

Test PASSed.

@patriknw
Copy link
Contributor

LGTM

1 similar comment
@drewhk
Copy link
Contributor

drewhk commented Sep 13, 2016

LGTM

@patriknw patriknw merged commit 4a7cd14 into akka:master Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants