ignore PubSub Status message from unknown node, #20846 #20847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproducer: 1. old cluster of node1, node2 and node3 2. shutdown node3 and start it again with same host:port, let it join itself and not the old cluster 3. node1 and node2 will continue to gossip to the node3 address and Status message is accepted and replied to (Delta is ignored from unknown node) Solution: * ignore status message from unknown node * also added a reply flag in the Status message to break the back-and-forth replies in case the deltas are not accepted, this is not needed for fixing this bug, but it adds an extra level of safety
| enterBarrier("after-1") | ||
| } | ||
|
|
||
| "handle restart of nodes with same address" in within(30 seconds) { |
There was a problem hiding this comment.
Not easy to test. I had to be somewhat "creative" to write a test for the issue. This was failing before the fix.
|
Refs #20846 |
|
Test FAILed. |
| val delta = collectDelta(otherVersions) | ||
| if (delta.nonEmpty) | ||
| sender() ! Delta(delta) | ||
| if (!reply && otherHasNewerVersions(otherVersions)) |
There was a problem hiding this comment.
reply is probably a misnomer as some kind of reply is clearly sent. Can you replace it with a more descriptive name?
|
LGTM |
|
bin compat failed, yeah I changed an internal message |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer:
join itself and not the old cluster
Status message is accepted and replied to (Delta is ignored from
unknown node)
Solution:
back-and-forth replies in case the deltas are not accepted,
this is not needed for fixing this bug, but it adds an extra
level of safety