-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fixes final stop message handling #26141 #26142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes final stop message handling #26141 #26142
Conversation
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
OK TO TEST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test FAILed. |
@patriknw I can't access Jenkins to see what's wrong, local sbt validatePullRequest was fine. And Jenkins says 0 tests failed regardless? |
@nvollmar are you sure you cannot access jenkins? if so then that isn't intentional and we'd like to fix it. Clicking on 'Details' next to 'Jenkins PR Validation' should bring you to https://jenkins.akka.io:8498/job/pr-validator-per-commit-jenkins/14308/, where 'Console Output' (on the left) should show the logs. Seems to work from an incognito window for me. |
The error seems to be a parboiled timeout while generating the docs with 'sbt paradox' - I'm not sure I've ever seen that before, perhaps it was a hardware hiccup.
trying again. |
PLS BUILD |
@raboof The reason is that Jenkins is on a non-standard port that is blocked in our office. |
Test PASSed. |
Adds a test and fix for Issue #26141