Skip to content

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Dec 20, 2018

Adds a test and fix for Issue #26141

@akka-ci
Copy link

akka-ci commented Dec 20, 2018

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@patriknw
Copy link
Contributor

OK TO TEST

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Dec 20, 2018
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw requested a review from chbatey December 20, 2018 06:48
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Dec 20, 2018
@akka-ci
Copy link

akka-ci commented Dec 20, 2018

Test FAILed.

@nvollmar
Copy link
Contributor Author

@patriknw I can't access Jenkins to see what's wrong, local sbt validatePullRequest was fine. And Jenkins says 0 tests failed regardless? Test FAILed. 8103 tests run, 498 skipped, 0 failed

@raboof
Copy link
Contributor

raboof commented Dec 20, 2018

@nvollmar are you sure you cannot access jenkins? if so then that isn't intentional and we'd like to fix it. Clicking on 'Details' next to 'Jenkins PR Validation' should bring you to https://jenkins.akka.io:8498/job/pr-validator-per-commit-jenkins/14308/, where 'Console Output' (on the left) should show the logs. Seems to work from an incognito window for me.

@raboof
Copy link
Contributor

raboof commented Dec 20, 2018

The error seems to be a parboiled timeout while generating the docs with 'sbt paradox' - I'm not sure I've ever seen that before, perhaps it was a hardware hiccup.

[12-20 07:49:31.078] [error] org.parboiled.errors.ParserRuntimeException: Error while parsing action 'Root/Sequence/ZeroOrMore/Sequence/Block/FirstOf/Sequence/FirstOf/Para/Sequence/Inlines/Sequence/ZeroOrMore/Sequence/InlineOrIntermediateEndline/Sequence/Inline/Inline_Action1' at input position (line 166, pos 74):
[12-20 07:49:31.078] [error] attaching it to our `factorials` source—after a small adaptation to turn the
[12-20 07:49:31.078] [error]                                                                          ^
[12-20 07:49:31.078] [error] 
[12-20 07:49:31.078] [error] org.pegdown.ParsingTimeoutException
[12-20 07:49:31.078] [error] 	at org.parboiled.MatcherContext.runMatcher(MatcherContext.java:367)
[12-20 07:49:31.078] [error] 	at org.parboiled.matchers.SequenceMatcher.match(SequenceMatcher.java:46)

trying again.

@raboof
Copy link
Contributor

raboof commented Dec 20, 2018

PLS BUILD

@akka-ci akka-ci added validating PR is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Dec 20, 2018
@nvollmar
Copy link
Contributor Author

nvollmar commented Dec 20, 2018

@raboof The reason is that Jenkins is on a non-standard port that is blocked in our office.
My other PR probably has the same issue.

@raboof
Copy link
Contributor

raboof commented Dec 20, 2018

@nvollmar aah, I've run into that myself before as well. Let's create a ticket, though it's not very a very high priority. Added #26143

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Dec 20, 2018
@akka-ci
Copy link

akka-ci commented Dec 20, 2018

Test PASSed.

@patriknw patriknw merged commit 6d6ac21 into akka:master Dec 21, 2018
@nvollmar nvollmar deleted the wip-26141-fix-backoff-supervisor branch December 21, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants