Provide minSequenceNr for snapshot deletion #25590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Sep 10, 2018
| deleteSnapshots(SnapshotSelectionCriteria(maxSequenceNr = toSequenceNr - 1)) | ||
| val deleteFrom = math.max(0, toSequenceNr - (keepNrOfBatches * snapshotAfter)) | ||
| val deleteTo = toSequenceNr - 1 | ||
| log.debug("PersistentShard messages to {} deleted successfully. Deleting snapshots from {} to {}", toSequenceNr, deleteFrom, deleteTo) |
There was a problem hiding this comment.
for consistency with other log messages add [] around the {}
| @@ -546,8 +537,13 @@ private[akka] class PersistentShard( | |||
| log.warning("PersistentShard snapshot failure: {}", reason.getMessage) | |||
|
|
|||
| case DeleteMessagesSuccess(toSequenceNr) ⇒ | |||
| log.debug("PersistentShard messages to {} deleted successfully", toSequenceNr) | |||
| deleteSnapshots(SnapshotSelectionCriteria(maxSequenceNr = toSequenceNr - 1)) | |||
| val deleteFrom = math.max(0, toSequenceNr - (keepNrOfBatches * snapshotAfter)) | |||
There was a problem hiding this comment.
shouldn't this be deleteTo - (keepNrOfBatches * snapshotAfter), e.g. otherwise would be wrong when keepNrOfBatches is 0
| persistent actors should use the `deleteSnapshots` method. | ||
| persistent actors should use the `deleteSnapshots` method. Depending on the journal used this might be inefficient. It is | ||
| best practice to do specific deletes with `deleteSnapshot` or to include a `minSequenceNr` as well as a `maxSequenceNr` | ||
| for the `SnapshotSelectionCriteria`. |
|
Test PASSed. |
|
Test PASSed. |
|
Set the milestone as promised it would be in the next release |
|
Test FAILed. |
Journals can use this to make the bulk deletion more efficient Use keepNrBatches to delete the last few snapshots in case previous deletes failed.
95a39f5 to
2ca2fe1
Compare
|
Test PASSed. |
johanandren
approved these changes
Sep 21, 2018
| log.debug("PersistentShard messages to {} deleted successfully", toSequenceNr) | ||
| deleteSnapshots(SnapshotSelectionCriteria(maxSequenceNr = toSequenceNr - 1)) | ||
| val deleteTo = toSequenceNr - 1 | ||
| val deleteFrom = math.max(0, deleteTo - (keepNrOfBatches * snapshotAfter)) |
There was a problem hiding this comment.
So the low end of the range is a performance opt to not always delete from 0?
There was a problem hiding this comment.
that's right, and it's used in Cassandra plugin when akka/akka-persistence-cassandra#394 has been released
There was a problem hiding this comment.
@patriknw @johanandren what is the consequence if I want to upgade akka-cluster version to the 2.5.17 or newer (let's say the latest 2.5.23) but with akka-persistence-cassandra-0.62? Is it possible or do I have to use minimum of akka-persistence-cassandra-0.90 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journals can use this to make the bulk deletion more efficient
Use keepNrBatches to delete the last few snapshots in case previous
deletes failed.
I started writing a test with a mock snapshot store but seemed overkill.