Skip to content

fix double return of recovery permit, #24003 #24006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2017
Merged

fix double return of recovery permit, #24003 #24006

merged 1 commit into from
Nov 17, 2017

Conversation

patriknw
Copy link
Contributor

  • when exception was thrown from RecoveryCompleted the
    permit was returned twice, resulting in negative balance

Refs #24003

@patriknw
fix double return of recovery permit, #24003
60e7a40 
* when exception was thrown from RecoveryCompleted the
  permit was returned twice, resulting in negative balance
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Nov 15, 2017
@akka-ci
Copy link

akka-ci commented Nov 15, 2017

Test PASSed.

johanandren
johanandren approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Nov 17, 2017
@patriknw patriknw merged commit b51d720 into master Nov 17, 2017
@patriknw patriknw deleted the wip-24003-permit-patriknw branch November 17, 2017 09:58
@zbynek001 zbynek001 mentioned this pull request Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

+1 more reviewer

@2m 2m 2m approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patriknw @akka-ci @2m @johanandren