-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Send Transistion on stay in FSM #15360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Transistion on stay in FSM #15360
Conversation
Can one of the repo owners verify this patch? |
Thanks Łukasz! I think this PR will trigger on both cases? Would you try to work a bit more no this? OK TO TEST |
Ok, this version does what we need it to. I'm thinking if we could implement it without having to change API... Since it's Thanks for the contribution and organising the hacker garden, I'll ping you tomorrow about this PR :-) |
Can one of the repo owners verify this patch? |
OK TO TEST |
If we go with the change of FSM.State we should perhaps put the the extra field a second parameter list, to avoid breaking unapply and equals. That parameter can be private, I think. The user is not supposed to create instances of FSM.State? |
@patriknw +1 LGTM otherwise |
Ah, of course: this change will also need to be incorporated in the documentation (API docs and reference docs). |
+1 though I welcome this change, I think it will likely break a lot of On Thu, Jun 5, 2014 at 4:12 AM, Roland Kuhn notifications@github.com
|
Add basic information in migration guide. Add custom copy to prevents API.
PLS BUILD |
Pull request validation: SUCCESS 👍 |
Cool. So this just needs docs in FSM, both java and scala, and the migration guide updated and we can merge it. |
the second parameter list looks good |
Improve part abut notification in documentation.
FSM notifies on same state trasisions | ||
==================================== | ||
``FSM`` notifies their subscribers about state transitions. In ``2.3.x`` when an Actor is in state ``A`` and ``goto(A)`` is invoked, | ||
no notifiaction will be send. In ``2.4.x`` FSMs send notifiaction about transisions which are done using ``goto()``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/send/sent/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos:
notifiaction -> notification
transisions -> transitions
…n-on-stay handle transitions when you goto(TheStateYouAreAlreadyIn).
@@ -93,6 +95,36 @@ class FSMTransitionSpec extends AkkaSpec with ImplicitSender { | |||
} | |||
} | |||
|
|||
"send information of Transision when staying in same state" in { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"when goto() the same state", the use of the word "staying" implies we're testing stay
Docs in Code is OK, we need improve the docs still a bit though @bambuchaAdm. |
Merging manually with typo fixes now, after agreeing to do so with @bambuchaAdm. |
Squashed and will merge the fixed up commit in: #15561 |
Implementation and test for #13970