Fix type checking errors #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checking passes now. I also included some changes which reduces the footprint of this change so that it becomes almost entirely just change of type annotations. This may be a bit on the pendatic side, and I would be fine if you keep the changes as they were, but I would rather keep refactoring seperate from changes to add typing.
|
Incremental progress is fine for me. Thank you! |
3dd2907
into
ajnelson-nist:apply_identified_node_to_graph_iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking passes now.
I also included some changes which reduces
the footprint of this change so that it becomes almost entirely just
change of type annotations.
This may be a bit on the pendatic side, and I would be fine if you keep
the changes as they were, but I would rather keep refactoring seperate from
changes to add typing.